Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7080 Updating Description IronPython3 #15

Conversation

RobertGlobant20
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 commented Jun 18, 2024

Purpose

Updating Description for IronPython3 package.
I was not able to test if the description was updated due that Dynamo is getting the data from the server, then first need to be published and then we will be able to test.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Updating Description for IronPython3 package.

Reviewers

@QilongTang
@mjkkirschner
@pinzart90
@jasonstratton
@AlexisErazoGlobant

FYIs

@reddyashish

Updating Description IronPython3 package.
@RobertGlobant20
Copy link
Contributor Author

@AlexisErazoGlobant could you review my changes. Thanks

@@ -3,7 +3,7 @@
"file_hash": null,
"name": "DynamoIronPython3",
"version": "1.4.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to bump up the version to 1.4.1?

@QilongTang QilongTang merged commit 80f34ee into DynamoDS:master Jul 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants